You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some issues to the codebase that make further development more heavy lifitng than I want it to be. I wanted to take time to outline further developments in this ticket.
Not a es6 codebase
The whole codebase is banking on node js and I would like it to be usable in a browser as well. best case no transpiling of any sort. In any case all code shall be pure es6 and use fetch for requests
hand crafted code
The whole code around the api is hand crafted and this research result in the docs were no clearly documented in a document but directly put into the codebase. This backfires now. It needs to be fixed with a machine readable definition of the API first. Swagger comes into mind and this homework has to be done. This way the requests can be generated from the definition and we can easier handle different response and error codes.
integration tests where unit tests are needed
We have a bunch of integration tests on the api, but these are very slow and needlesly shaky.
What is next?
Definition of a swagger API description
Adding first fixtures from the etherscan server to allow for local unit testing.
Creating a client from the spec
transpiling node js code from the es6 code
Running test suites with teh created clients
Profit!
If you are willing to help or contribute! ;) Please do so .. I will open a branch soon
The text was updated successfully, but these errors were encountered:
@sebs i'd be down to help. do you have issues to work on? also, would you be interested in gprc? cross language api may be useful to alleviate some of the burden
There are some issues to the codebase that make further development more heavy lifitng than I want it to be. I wanted to take time to outline further developments in this ticket.
Not a es6 codebase
The whole codebase is banking on node js and I would like it to be usable in a browser as well. best case no transpiling of any sort. In any case all code shall be pure es6 and use fetch for requests
hand crafted code
The whole code around the api is hand crafted and this research result in the docs were no clearly documented in a document but directly put into the codebase. This backfires now. It needs to be fixed with a machine readable definition of the API first. Swagger comes into mind and this homework has to be done. This way the requests can be generated from the definition and we can easier handle different response and error codes.
integration tests where unit tests are needed
We have a bunch of integration tests on the api, but these are very slow and needlesly shaky.
What is next?
Profit!
If you are willing to help or contribute! ;) Please do so .. I will open a branch soon
The text was updated successfully, but these errors were encountered: