Better looking "addlink" page when logged out. #141
Comments
|
Hi @cladmi we maintain a temporary community fork at https://github.com/shaarli/Shaarli/ waiting for @sebsauvage to decide if he wants to merge our changes or not. We already have added some bugfixes and enhancements. This is a minor but annoying bug. I've opened shaarli#47 to keep track of it and we will likely fix this soon. Can you close this issue and follow/comment on the new one? It helps clearing up the bug tracker. Thanks |
nodiscc
added a commit
to shaarli/Shaarli
that referenced
this issue
Nov 21, 2014
Prevents ?do=addlink from generating a 404 if the user is not logged in Fixes sebsauvage#141 Fixes #47
pikzen
pushed a commit
to pikzen/Shaarli
that referenced
this issue
Mar 29, 2015
Add URL cleaning filters + refactoring
fanch317
pushed a commit
to fanch317/Shaarli
that referenced
this issue
Sep 1, 2015
Relates to sebsauvage#141 Relates to sebsauvage#133 Modifications - move URL cleanup to `application/Url.php` - rework the cleanup function - fragments: `#stuff` - GET parameters: `?var1=val1&var2=val2` - add documentation (APIs the params belong to) - add test coverage Reference - http://php.net/parse_url - http://php.net/manual/en/language.oop5.magic.php#language.oop5.magic.tostring Signed-off-by: VirtualTam <virtualtam@flibidi.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When accessing the
do=addlinkpage as logged-out it generates a 404 error.I personally thought, the first times that my shaarli/web server went down, and not that I was viewing a logged-in only page after my login timed out.
For sure I didn't even read the written message.
I would prefer that the "regular" pages (I mean existing pages when logged in) viewed logged out present a "normal" view looking like a regural shaarli page and not a black on white 404 error page.
Regards,
cladmi
The text was updated successfully, but these errors were encountered: