Prevent data leaks with CSP and HSTS Headers #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These headers add two security layers against MITM and XSRF attacks, respectively. Since security is a major feature of this project, they should not be ignored. * Adding the `Strict-Transport-Security` header, you locks the traffic on https protocol for a day (86400 seconds). If the server is not https-capable, this security layer is simply ignored by browser. See: https://developer.mozilla.org/en-US/docs/Security/HTTP_Strict_Transport_Security * Adding the `Content-Security-Policy` header, you forbid the browser to load scripts from another domain. This help to address tricky code injections (e.g. unicode tag attributes bypass or `javascript:` URI in users comments). See: https://developer.mozilla.org/en-US/docs/Security/CSP/CSP_policy_directives#script-src For paranoid people, you should even use `header("Content-Security-Policy: default-src 'self'");` to prevent anything to be loaded except for the very server which run ZeroBin.
|
@Talenka Please note that it might take some time until this will be merged by @sebsauvage (assuming it works, sorry, no time to test right now). See #63 for details! Conceptually I really like your approach. I assume it's no big deal to fix any remaining issues. |
|
@ulikoehler OK I'll work on your fork for now. |
jelhan
added a commit
to jelhan/croodle
that referenced
this pull request
Dec 13, 2013
Set Content-Type to application/json and charset to utf-8 to tell the browser how to handle the response Lock traffic on https for 1 day (86400 seconds) by Strict-Transport-Security Forbid the browser to load scripts from another domain by Content-Securty-Policy Last ones were adopted by Talenka's Pull Request for ZeroBin: sebsauvage/ZeroBin#70
|
Thank you for the work (ulikoehler@18571ba). It looks interesting, but it currently breaks discussions. |
blackout314
pushed a commit
to GrayHats/ZeroBin
that referenced
this pull request
Dec 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These headers add two security layers against MITM and XSRF attacks, respectively. Since security is a major feature of this project, they should not be ignored.
Strict-Transport-Securityheader, you locks the traffic on https protocol for a day (86400 seconds). If the server is not https-capable, this security layer is simply ignored by browser. See: https://developer.mozilla.org/en-US/docs/Security/HTTP_Strict_Transport_SecurityContent-Security-Policyheader, you forbid the browser to load scripts from another domain. This help to address tricky code injections (e.g. unicode tag attributes bypass orjavascript:URI in users comments). See: https://developer.mozilla.org/en-US/docs/Security/CSP/CSP_policy_directives#script-srcFor paranoid people, you should even use
header("Content-Security-Policy: default-src 'self'");to prevent anything to be loaded except for the very server which run ZeroBin.