get_cik_map() causes AttributeError due object type "None" in returned list

[niklascube]

Description
Using the method get_cik_map() of the module cik_lookup an AttributeError with the message "'NoneType' object has no attribute 'upper'" is generated. This error occurs because in the returned list an object has the type NULL.

Object of matter: {"cik_str":1104206,"ticker":"RIGG","title":null}

To Reproduce
Just start the method get_cik_map() from module cik_lookup.

Error

My system
MacBook Pro 2021

[niklascube]

Just saw, somebody already tried to fix the issue by just skipping the entry. I have something in store which replaces the skip with an empty string in the object.

[jackmoody11]

Hi @niklascube, I think this should be fixed. Can you try using the latest code in master?

See #256.

[niklascube]

Hi @niklascube, I think this should be fixed. Can you try using the latest code in master?

See #256.

Not really. The current solution skips the whole object, so that the mentioned RIGG entry is deleted. My solution does not skip the object and returns the object with an empty title. The cik is returned probably then.

[niklascube]

I've made a suggestion on my forked repo: niklascube@495c688

@jackmoody11 may you have a look?

[jackmoody11]

@niklascube if multiple tickers or company names are missing, won't the empty string key be overwritten?