Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ssl issue and async_timeout #292

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wmaiouiru
Copy link

@wmaiouiru wmaiouiru commented Jun 3, 2023

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • added entry to docs/whatsnew latest version

Incorporate recommended fixes for async_timeout:
#281

Fix issue with aiohttp:
aio-libs/aiohttp#955

ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1131)

Tested with:

        daily_filings = filings(start_date=date(2023, 6, 2),
                                user_agent="wmaiouiru",
                                ssl_flag=False)
        daily_urls = daily_filings.get_urls()
        daily_filings.save(working_dir)

@jackmoody11
Copy link
Member

Thanks for the PR @wmaiouiru! I haven't had this issue and don't know that we want to force verify_ssl to be off for everybody. Maybe we could make it an argument that defaults to True but could be turned to False if users face this issue?

@wmaiouiru
Copy link
Author

Thanks for the PR @wmaiouiru! I haven't had this issue and don't know that we want to force verify_ssl to be off for everybody. Maybe we could make it an argument that defaults to True but could be turned to False if users face this issue?

That make sense, let me refactor that.

Curious why there is no typehint and mypy applied to this code base.

@wmaiouiru
Copy link
Author

@jackmoody11

Updated the PR with default SSL flag to True.

Tested with:

        daily_filings = filings(start_date=date(2023, 6, 2),
                                user_agent="wmaiouiru",
                                ssl_flag=False)
        daily_urls = daily_filings.get_urls()
        daily_filings.save(working_dir)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants