Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: seccomp() syscall and TSYNC flag support never configured #20

Closed
justincormack opened this issue Nov 10, 2015 · 3 comments
Closed
Assignees
Milestone

Comments

@justincormack
Copy link
Contributor

Currently the tsync support is wrapped with HAVE_SECCOMP but there is actually no configure test, perhaps as no existing libc has the seccomp call available.

However it would be perfectly normal to just call seccomp(2) with syscall() as glibc policy seems to be mostly not to expose specialist syscalls at all.

In which case the library could attempt to use syscall(SYS_seccomp, ...) if tsync was set, and fail the filter load if not, rather than just having a tsync option which is not usable even if supported by the kernel.

This behaviour would seem more useful as tsync support is quite widespread, and it is important for many applications. Otherwise the Go libseccomp wrapper should have a warning saying always use runtime.LockOSThread() if you use this library or filtering may not be applied to the calls you expect.

@pcmoore pcmoore changed the title tsync support never configured RFE: seccomp() syscall and TSYNC flag support never configured Nov 11, 2015
@pcmoore
Copy link
Member

pcmoore commented Nov 11, 2015

As noted in the autoconfigure script, this functionality was added but disabled pending further testing.

@pcmoore pcmoore modified the milestone: v2.3 Feb 9, 2016
@pcmoore pcmoore self-assigned this Feb 9, 2016
@pcmoore
Copy link
Member

pcmoore commented Feb 22, 2016

I've enabled the seccomp() syscall, a thread sync as a result, in a1f144a, but additional testing is needed on the different platforms due to the nature of the implementation.

@pcmoore
Copy link
Member

pcmoore commented Feb 26, 2016

See commit 08a682a. We've had enough testing that I'm reasonably confident in considering this issue resolved.

@pcmoore pcmoore closed this as completed Feb 26, 2016
marmarek added a commit to marmarek/qubes-vmm-xen-stubdom-linux that referenced this issue Jan 17, 2019
Support for SCMP_FLTATR_CTL_TSYNC (required by qemu) in theory is in
2.2.0, but it is not enabled there yet. Requires libseccomp >= 2.3.0 to
actually have this flag functional.
See seccomp/libseccomp#20
marmarek added a commit to marmarek/qubes-vmm-xen-stubdom-linux that referenced this issue Jan 18, 2019
Support for SCMP_FLTATR_CTL_TSYNC (required by qemu) in theory is in
2.2.0, but it is not enabled there yet. Requires libseccomp >= 2.3.0 to
actually have this flag functional.
See seccomp/libseccomp#20
marmarek added a commit to marmarek/qubes-vmm-xen-stubdom-linux that referenced this issue Feb 26, 2019
Support for SCMP_FLTATR_CTL_TSYNC (required by qemu) in theory is in
2.2.0, but it is not enabled there yet. Requires libseccomp >= 2.3.0 to
actually have this flag functional.
See seccomp/libseccomp#20
marmarek added a commit to QubesOS/qubes-vmm-xen-stubdom-linux that referenced this issue Apr 7, 2019
Support for SCMP_FLTATR_CTL_TSYNC (required by qemu) in theory is in
2.2.0, but it is not enabled there yet. Requires libseccomp >= 2.3.0 to
actually have this flag functional.
See seccomp/libseccomp#20

(cherry picked from commit e762ebb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants