Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: new process docs and various updates #158

Closed
wants to merge 1 commit into from

Conversation

pcmoore
Copy link
Member

@pcmoore pcmoore commented Jul 2, 2019

A number of updates mainly focused on paving the way for multiple
maintainers and making better use of the GitHub vulnerability
reporting tools.

Signed-off-by: Paul Moore paul@paul-moore.com

A number of updates mainly focused on paving the way for multiple
maintainers and making better use of the GitHub vulnerability
reporting tools.

Signed-off-by: Paul Moore <paul@paul-moore.com>
@pcmoore
Copy link
Member Author

pcmoore commented Jul 2, 2019

These are the changes from issue #146, still look okay to you @drakenclimber? If so, can I get an ACK?

@pcmoore pcmoore self-assigned this Jul 2, 2019
@pcmoore pcmoore mentioned this pull request Jul 2, 2019
7 tasks
@pcmoore pcmoore added this to the v2.4.2 milestone Jul 2, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.794% when pulling f3480db on pcmoore:working-docs into 5fc2242 on seccomp:master.

@pcmoore
Copy link
Member Author

pcmoore commented Jul 16, 2019

Ping @drakenclimber ?

The maintainer which merged the patch into the repository should add their
sign-off after ensuring that it is correct to do so (see the documentation on
submitting patches); if it is not correct for the maintainer to add their
sign-off, it is likely they patch should not be merged. The maintainer should
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is likely they patch

nitpick - it is likely the patch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, fixed.

@drakenclimber
Copy link
Member

drakenclimber commented Jul 16, 2019

Sorry about that. I was out a few days, and obviously spacing off a few others :(.

I had one really nitpicky comment, but otherwise it looks really good. Thanks for putting it together.

Acked-by: Tom Hromatka <tom.hromatka@oracle.com>

@pcmoore
Copy link
Member Author

pcmoore commented Jul 22, 2019

Thanks @drakenclimber, I fixed the typo you found, added your ACK, and merged the patch as 4bec773.

@pcmoore pcmoore closed this Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants