BUG: fix s390/s390x handling of shm* syscalls #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On s390, shmat, shmdt, shmget, and shmctl can be done either via sockets or ipc. Prior to this commit, the s390 code only supported these calls via sockets. This commit adds support for both sockets and ipc. Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
On s390x, shmat, shmdt, shmget, and shmctl can be done either via sockets or ipc. Prior to this commit, the s390x code only supported these calls via sockets. This commit adds support for both sockets and ipc. Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
|
@pcmoore, I think this is the last open issue for the v2.4.3 release. |
|
These changes look reasonable, but lets see if @cpaelzer can give them a test (I don't have access to s390[x] hardware). As an aside, look at that code coverage :} |
pcmoore
changed the title
|
At this point, let's just assume it all works on s390[x], if there is a bug we'll fix it. Merged via 0a4c030, thanks @drakenclimber. |
|
Merged into the release-2.4 branch via 266e1b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #193 exposed a few cases where libseccomp isn't completely supporting
shm*()syscalls on s390/s390x. This commit adds IPC support forshmat(),shmdt(),shmget(), andshmctl(). Socket support for the aforementioned syscalls was unchanged and should still work as before.I ran this through
arch-syscall-validate, but I really don't have a way to test these changes. @cpaelzer or others - do you have a way to test this?