aarch64: Use architecture specific header to general syscalls #235
Conversation
|
FYI, this is to address https://launchpad.net/bugs/1877633 |
|
The changes look good to me. I tested out the @alexmurray - could you please update the patch with your signed-off-by? Thanks!
@pcmoore, I originally tagged this as v2.5, but I'm now second guessing myself and wondering if this deserves a v2.4.4 release of its own. Thoughts? |
|
Thanks @alexmurray for the fix, but as @drakenclimber already pointed out, please include your sign-off in the patch. We've written up a guide to submitting patches in the CONTRIBUTING.md doc if that helps. @drakenclimber, yes, I think we need this both for v2.5.0 and v.2.4.x. Do you want to create a new issue for this for the v2.4.4 milestone? We obviously can't backport this fix. |
|
Sure. I can take care of the v2.4.4 side of things. |
This ensures clone3, getrlimit and setrlimit are defined for aarch64 - also update syscalls.csv from 5.6.0 to pick up these new syscalls Signed-off-by: Alex Murray <alex.murray@canonical.com> Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com>
alexmurray
force-pushed
the
fix-missing-aarch64-syscalls
branch
from
94ef9ca
to
fff41e9
Compare
|
Apologies for missing CONTRIBUTING.md - have added my signed-off-by and Tom's reviewed-by. @drakenclimber I can try take a look at 2.4.4 if you need - let me know. |
That would be really helpful :)! Thanks. |
|
Looks good to me, merged via 7780b08 - thanks everyone! |
modify use of getrlimit() to not be fatal if an error occurs Some container configurations might cause getrlimit() and setrlimit() to fail. lighttpd will issue error trace if this occurs, but will now proceed. x-ref: "aarch64: Use architecture specific header to general syscalls" seccomp/libseccomp#235 "Rasperry Docker PiHole / "Starting lighttpd" Hanging" pi-hole/docker-pi-hole#593 "Pi-hole runs on podman" https://discourse.pi-hole.net/t/pi-hole-runs-on-podman/34719/5
modify use of getrlimit() to not be fatal if an error occurs Some container configurations might cause getrlimit() and setrlimit() to fail. lighttpd will issue error trace if this occurs, but will now proceed. x-ref: "aarch64: Use architecture specific header to general syscalls" seccomp/libseccomp#235 "Rasperry Docker PiHole / "Starting lighttpd" Hanging" pi-hole/docker-pi-hole#593 "Pi-hole runs on podman" https://discourse.pi-hole.net/t/pi-hole-runs-on-podman/34719/5
This ensures clone3, getrlimit and setrlimit are defined for aarch64 - also
update syscalls.csv from 5.6.0 to pick up these new syscalls