Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS catalina support #2139

Merged
merged 2 commits into from
Jul 14, 2019
Merged

macOS catalina support #2139

merged 2 commits into from
Jul 14, 2019

Conversation

guedou
Copy link
Member

@guedou guedou commented Jul 12, 2019

This fixes #2134 and adds mocked test for read_routes on 10.13.

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #2139 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
- Coverage   87.31%   87.31%   -0.01%     
==========================================
  Files         199      199              
  Lines       45184    45189       +5     
==========================================
+ Hits        39454    39456       +2     
- Misses       5730     5733       +3
Impacted Files Coverage Δ
scapy/arch/unix.py 74.19% <100%> (+0.6%) ⬆️
scapy/autorun.py 78.51% <0%> (-4.14%) ⬇️
scapy/layers/tls/record.py 92.1% <0%> (-1.17%) ⬇️
scapy/automaton.py 87.2% <0%> (-0.4%) ⬇️
scapy/layers/inet6.py 88.22% <0%> (-0.06%) ⬇️
scapy/arch/windows/__init__.py 71.96% <0%> (+0.15%) ⬆️
scapy/layers/tls/record_sslv2.py 87.7% <0%> (+1.67%) ⬆️
scapy/pton_ntop.py 97.26% <0%> (+8.21%) ⬆️

@gpotter2
Copy link
Member

All good to me ! Thanks for the quick fix

@gpotter2
Copy link
Member

Could you also add the tests for IPv6 ?
The routes were also provided in the results I posted previously

@guedou
Copy link
Member Author

guedou commented Jul 13, 2019 via email

@gpotter2 gpotter2 merged commit 617e58c into secdev:master Jul 14, 2019
@Tom73525-zz
Copy link

I was working on the same project on ubuntu for a while and then got back here on Catalina to update scapy. Worked like a charm. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac OS Catalina
3 participants