[Sema] MemberAccess #104
Merged
[Sema] MemberAccess #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 66.58% 66.33% -0.25%
==========================================
Files 97 97
Lines 13398 13480 +82
Branches 1987 2013 +26
==========================================
+ Hits 8921 8942 +21
- Misses 3487 3538 +51
- Partials 990 1000 +10
Continue to review full report at Codecov.
|
hydai
requested changes
Jul 26, 2021
| Actions.Diag(Base->getLocation().getBegin(), | ||
| diag::err_super_in_noninheritance_contract); | ||
| } | ||
| for (auto F : Bases[1]->getFuncs()) |
There was a problem hiding this comment.
Here is a magic number 1, what does it mean?
| } break; | ||
| case Type::Category::Address: { | ||
| // TODO: Handle Address case | ||
| // TODO: Address.send(x), should bypass send and check x. |
There was a problem hiding this comment.
Do we need to throw an unimplemented error here?
| @@ -439,6 +439,7 @@ class TypeResolver : public StmtVisitor { | |||
| ME.setLibraryAddress(Address); | |||
| return; | |||
| } | |||
| // TODO : remove this | |||
hydai
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to issue #92 , some impartment part can not be implemented until we solve it.
Therefore it is required to add a lot bypass.