Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade crun to latest version, current 1.8.4 #29

Merged
merged 6 commits into from
May 2, 2023
Merged

Conversation

dm4
Copy link
Member

@dm4 dm4 commented Apr 17, 2023

  • Upgrade crun to latest version
  • Add kwasm tests and corresponding README

Copy link
Member

juntao commented Apr 17, 2023

Hello, I am a serverless review bot on flows.network. Here are my reviews of code commits in this PR.


Commit c753226aab8bfef0bb43194065244a6115bc254b

The pull request upgrades crun to version 1.8.4 and applies this change across 8 different files. The exclusion of certain crun and wasmge versions in some jobs has been removed.

A potential problem to consider is whether there are any compatibility issues between the upgraded crun version and other dependencies in the project. Additionally, it would be beneficial to look into any reported bugs or issues with this new version of crun to ensure that the upgrade will not cause any critical problems.

@dm4 dm4 changed the title Upgrade crun to latest version, current 1.8.2 Upgrade crun to latest version, current 1.8.4 Apr 18, 2023
@dm4 dm4 marked this pull request as ready for review April 18, 2023 10:28
@dm4 dm4 requested a review from hydai April 18, 2023 10:28
@dm4
Copy link
Member Author

dm4 commented Apr 20, 2023

Also fix the CI warning by upgrade to actions/checkout@v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants