This repository has been archived by the owner on May 31, 2023. It is now read-only.
update json to 1.8.3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't see this, I am closing my PR Just so that everyone know, with 1.8.1, it does not work on ruby 2.3.0, but with 1.8.3, it will work on 2.0.0 and on |
|
Added a new fix and tagged my fork to 1.1.3 now. Your version of the agent leaks file descriptors, because each poll cycle a new redis client is initialised. |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated json to 1.8.3 because json 1.8.1 failed to compile.
Please also push and create a new tag. (1.1.1 is missing for example).