Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version upper bound before adjust gpflow>=2.6 #83

Closed
zjowowen opened this issue Oct 7, 2022 · 4 comments
Closed

Add version upper bound before adjust gpflow>=2.6 #83

zjowowen opened this issue Oct 7, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@zjowowen
Copy link

zjowowen commented Oct 7, 2022

Describe the bug
GPflow>=2.6 seems to change the way to calculate likelihood p(Y|F,X) from by using F and Y to by using X, F and Y.
I guess this change would be incompatible to the current gpflux develop branch.

To reproduce
Steps to reproduce the behaviour:

  1. git clone https://github.com/secondmind-labs/GPflux.git
  2. pip install -e .
  3. python ./gpflux/docs/notebooks/intro.py

An error will occur at Line 99.

System information

  • OS: Ubuntu20.04
  • Python version: 3.9.13
  • GPflux version:
    develop branch f95e1cb
  • TensorFlow version: 2.8.3
  • GPflow version: 2.6.1

Additional context
It would be ok if switching to gpflow==2.5.2

@zjowowen zjowowen added the bug Something isn't working label Oct 7, 2022
@hsvalladares
Copy link

Hi zjowowen. Thanks for raising this point. I am also facing the same issue. I am trying to run the other tutorials and they fail on that point. What would be the solution to overcome this issue?

@zjowowen
Copy link
Author

Hi, hsvalladares. You can downgrade to gpflow==2.5.2 by pip install.
Or, you can try a developing branch by Jesnie, https://github.com/secondmind-labs/GPflux/tree/jesper/gpflow260
It seems to work, but I am not sure because it has not been merged yet.

@hsvalladares
Copy link

Hi zjowowen. Thanks for your suggestion. gpflow==2.5.2 works perfectly!

@st--
Copy link
Member

st-- commented Mar 28, 2023

This was an unfortunate backwards-compatibility-breaking change upstream in GPflow. GPflux has subsequently been adjusted in #84 , and released in 0.3.1. Closing this issue as it's no longer applicable to the latest version.

@st-- st-- closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants