Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer GPflow and TensorFlow. #84

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Update to newer GPflow and TensorFlow. #84

merged 1 commit into from
Oct 18, 2022

Conversation

jesnie
Copy link
Collaborator

@jesnie jesnie commented Oct 14, 2022

Update to make GPflux compatible with newer versions of GPflow, that require an additional X parameter in the likelihoods.
In this PR I just pass a dummy None value as X. Alternatively we could:

  1. I don't know Keras and GPflux well, but maybe we can find a "real" value of X to use?
  2. Do we want to attempt to write code that's compatible with earlier version of GPflow as well? I suppose we could add an if somewhere?

@SebastianPopescu
Copy link
Collaborator

all seems good from an initial view.

Copy link
Collaborator

@SebastianPopescu SebastianPopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think passing None is still not best practice as if someone wants to actually build a heteroskedastic model in GPflux they are gonna have a harder time to modify stuff in the lack of a blueprint, but it does the job for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants