Support TF 2.15 #101
Merged
Support TF 2.15 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f9d95b5.
This reverts commit 3e4f98c.
Behavior of tensorflow ObjectIdentitySet has change in 2.15, resulting in the set equality comparing wrappers instead of wrapped values. See tensorflow/tensorflow@bc28335.
uri-granta
approved these changes
Jan 8, 2024
.github/workflows/quality-check.yaml
Outdated
| @@ -22,7 +22,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.7", "3.8", "3.9", "3.10"] | |||
| tensorflow: ["~=2.5.0", "~=2.6.0", "~=2.7.0", "~=2.8.0", "~=2.9.0", "~=2.10.0", "~=2.11.0", "~=2.12.0"] | |||
| tensorflow: ["~=2.5.0", "~=2.6.0", "~=2.7.0", "~=2.8.0", "~=2.9.0", "~=2.10.0", "~=2.11.0", "~=2.12.0", "~=2.15.0"] | |||
There was a problem hiding this comment.
do we not want to test on the intermediate values too?
There was a problem hiding this comment.
Wasn't sure, thought that would be a lot of combinations. I'll go ahead and add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for tensorflow 2.15.
Required fixing of two issues:
ImportError: cannot import name 'Self' from 'typing_extensions' .... Worked around by limiting mypy version for older python versions.tensorflow.python.util.object_identity.ObjectIdentitySethas changed such that the set equality now compares the internal wrappers instead of the wrapped objects (see tensorflow/tensorflow@bc28335). This resulted in a failing test. The test has been updated to directly compare the objectids, instead of using the internal tensorflow class. Note: this class is also used inoptimization/keras_natgrad.py, but that behaviour hasn't changed and should continue to work. So that has been left alone in this PR.