Document pickling acquisition functions #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstojic
approved these changes
Jul 3, 2023
| @@ -168,4 +168,23 @@ def plot_ask_tell_regret(ask_tell_result): | |||
|
|
|||
|
|
|||
| # %% [markdown] | |||
| # A word of warning. This serialization technique is not guaranteed to work smoothly with every Tensorflow-based model, so apply to your own problems with caution. | |||
| # In some more complicated scenarios we may also wish to serialise the acquisition function, rather than creating a new one from the models and data, as it may contain stochastic internal data. This is not an issue here (where we used the default `EfficientGlobalOptimization` rule and `ExpectedImprovement` function) but we can demonstrate it neverthless: | |||
There was a problem hiding this comment.
perhaps mention an acq function where there is an internal state?
There was a problem hiding this comment.
Can you remind me what the archetypal use case for this was?
There was a problem hiding this comment.
any that is using trajectory samplers I think, bcs they have internal state acq func has stochastic internal state... not sure about any others, perhaps one of the Henry's acq functions has internal states?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.