Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ask_tell global dataset_len detection #853

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix ask_tell global dataset_len detection #853

merged 1 commit into from
Jun 6, 2024

Conversation

khurram-ghani
Copy link
Collaborator

Related issue(s)/PRs: None

Summary

Quick fix for dataset_len detection. tf.unique returns a list of indices of the same length as the input, so we should use unique_lens to check the length instead.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@khurram-ghani khurram-ghani requested a review from avullo June 6, 2024 14:58
avullo
avullo approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@avullo avullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@khurram-ghani khurram-ghani merged commit f612e90 into develop Jun 6, 2024
12 checks passed
@khurram-ghani khurram-ghani deleted the khurram/fix_datset_len branch June 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avullo avullo avullo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khurram-ghani @avullo