Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate video detail and audio settings into preferences #29

Open
Quintus opened this issue Apr 4, 2014 · 0 comments
Open

Integrate video detail and audio settings into preferences #29

Quintus opened this issue Apr 4, 2014 · 0 comments

Comments

@Quintus
Copy link
Member

Quintus commented Apr 4, 2014

This code in preferences.cpp:

    // FIXME: Merge these settings with the other ordinary settings
    // in a cPreferences instance! The following lines set global
    // variables, which from the outside is totally unexpected.
    // This must be done in main.cpp instead, where the preferences
    // are loaded!
    pVideo->m_geometry_quality = loader.Get_Video_Geometry_Detail();
    pVideo->m_texture_quality  = loader.Get_Video_Texture_Detail();
    pAudio->m_music_volume     = loader.Get_Audio_Music_Volume();
    pAudio->m_sound_volume     = loader.Get_Audio_Sound_Volume();

sets global variables where it is totally unexpected from the outside. The 4 relevant settings must be included into cPreferences and the corresponding globals must be set in the calling context in main.cpp on game startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant