Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sml] optimize preprocessing by eliminating unnecessary where function #622

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

winnylyc
Copy link
Contributor

Pull Request

What problem does this PR solve?

Small optimization in sml/preprocessing
Eliminate where function in original solution.
In original version, where was used only for eliminating redundant computation branch, however both branches within the where function still need to be computed, which does not meet the desired outcome.
By eliminating the where function, the computation can be reduced without affecting the result.

Copy link
Contributor

@deadlywing deadlywing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadlywing deadlywing merged commit d1850ed into secretflow:main Mar 26, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants