Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Alt.js with Redux and upgrade react-scripts #112

Merged
merged 56 commits into from
Jan 30, 2022
Merged

Conversation

dlajarretie
Copy link
Contributor

@dlajarretie dlajarretie commented Oct 30, 2021

Current status

βœ… = done
πŸŸ₯ = broken
❓ = not tested yet
✴️ = already broken in production

Login / Sign up :

  • βœ… Sign up
  • βœ… Sign in without 2FA
  • βœ… Sign in with 2FA
  • βœ… Sign in with shortlogin

Secret list :

  • βœ… Display empty secret list
  • βœ… Display home secret list
  • βœ… Display "all" secret list
  • βœ… Display "my" secret list
  • βœ… Display "shared" secret list
  • βœ… Display folders
  • βœ… Navigate inside folders
  • βœ… Breadcrumbs
  • βœ… Delete folder
  • βœ… Search folder
  • βœ… Delete secret
  • βœ… Search secret
  • ✴️ Refresh secret list - Bug: First refresh reloads the previous state
  • βœ… Drag-n-drop secret in folder
  • βœ… Remove secret from folder
  • βœ… Shared with
  • βœ… Sort alphabetically

Secret/Folder modal :

  • βœ… Create secret
  • βœ… Show secret
  • βœ… Edit secret
  • βœ… Share secret
  • βœ… Unshare secret
  • βœ… Update sharing permissions on secret
  • βœ… Rename secret
  • βœ… Generate password
  • βœ… Create folder
  • βœ… Show folder
  • βœ… Share folder
  • βœ… Unshare folder
  • βœ… Update sharing permissions on folder
  • βœ… Rename folder
  • βœ… Create secret inside folder
  • βœ… Create secret inside nested folder
  • βœ… Create folder inside folder
  • βœ… Create folder inside nested folder

Import / Export :

  • βœ… Export secrets
  • βœ… Import secrets

Settings :

  • βœ… Enable 2FA
  • βœ… Enable shortlogin
  • βœ… Enable auto logout
  • βœ… Change master password

Already done :

  • Did a naive rewrite of all Alt.js stores/actions using Redux Toolkit
  • Got rid of Immutable.js (reducers use immer for immutability)
  • Rewrote all components to connect them to the Redux store instead of Alt.js stores
  • Fixed the dreaded bug of the latest user not appearing in the share list
  • Fixed the also dreaded bug of cursor jumping to the end when editing input values

Remaining tasks :

  • Deploy to beta.secret-in.me

@agix
Copy link
Contributor

agix commented Oct 30, 2021

Oh waow ! @Calyhre would be prode of you

@agix
Copy link
Contributor

agix commented Dec 15, 2021

<3

@agix
Copy link
Contributor

agix commented Jan 24, 2022

πŸ•Ί

@dlajarretie
Copy link
Contributor Author

Almost there πŸ₯΅

Copy link
Collaborator

@Calyhre Calyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlajarretie dlajarretie marked this pull request as ready for review January 26, 2022 20:57
Copy link
Contributor

@agix agix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write better commit message ?

:trollface:

@dlajarretie dlajarretie merged commit a61f057 into master Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants