Fetch BTC transaction from txId #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-2480 Add fetch BTC and Ordinal transaction functions
add functions to fetch single BTC and ordinal transaction from txId using mempool.space API |
m-aboelenein
approved these changes
Jul 27, 2023
api/esplora/esploraAPiProvider.ts
Outdated
| @@ -146,6 +146,10 @@ export default class BitcoinEsploraApiProvider extends ApiInstance implements Bi | |||
| return this.httpGet<esplora.Transaction[]>(`/address/${address}/txs`); | |||
| } | |||
|
|
|||
| async getBtcTransaction(txid: string): Promise<esplora.Transaction> { | |||
There was a problem hiding this comment.
should be simplified to be getTransaction
|
m-aboelenein
approved these changes
Aug 1, 2023
teebszet
deleted the
abdulhaseeb/eng-2480-add-fetch-btc-and-ordinal-transaction-functions
branch
This was referenced Aug 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
We need functions to fetch individual BTC and Ordinal transaction from txId. We fetch the transaction from transaction status screens to show the transaction detail after the tx is broadcasted successfully.
Issue Link: https://linear.app/xverseapp/issue/ENG-2480/add-fetch-btc-and-ordinal-transaction-functions
Context Link (if applicable): https://linear.app/xverseapp/issue/ENG-2427/update-transaction-status-screens
🔄 Changes
added two functions in api/btc.ts. to fetch BTC and Ordinal transaction from txId.
Changes:
Impact:
✅ Review checklist
Please ensure the following are true before merging: