fix: remove padding input from ledger PSBT signing

[victorkirov]

🔘 PR Type

What kind of change does this PR introduce?

• Bugfix
• Enhancement

📜 Background

Ledger has an issue with signing PSBTs where the outputs spend more than the inputs. We were adding a dummy input to cater for this but we weren't removing that input before returning the signed PSBT.

🔄 Changes

Does this PR introduce a breaking change?

• Yes, Incompatible API changes
• No, Adds functionality (backwards compatible)
• No, Bug fixes (backwards compatible)

Changes:

• We now remove the dummy input

✅ Review checklist

Please ensure the following are true before merging:

• Code Style is consistent with the project guidelines.
• Code is readable and well-commented.
• No unnecessary or debugging code has been added.
• Security considerations have been taken into account.
• The change has been manually tested and works as expected.
• Breaking changes and their impacts have been considered and documented.
• Code does not introduce new technical debt or issues.

[teebszet]

is the manual test to use a ledger device to sign any psbt request?

[victorkirov]

is the manual test to use a ledger device to sign any psbt request?

Yes, just make sure we can still list on ME 👍

[github-actions]

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@5.2.0-40afbac

[teebszet]

Screen.Recording.2023-12-12.at.3.00.52.PM.mov

ME listing looks good