Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: trigger npm publish on pr merge #312

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Dec 7, 2023

🔘 PR Type

  • CI related changes
  • Other... Please describe: build with node 18

📜 Background

Future work from here:
https://www.notion.so/xverseapp/Xverse-Core-Release-Instructions-0842d3b87f0142fbb27766e80f6b1401

🔄 Changes

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, CI only

Changes:

  • chore: refactored the workflows.
    • npm publish and github release publish are now triggered from merge of the release PR
    • no longer need the prerelease conditionals on the publish-gpr job
  • chore: use node 18 for CI builds

Impact:

  • ci only

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@5.2.0-ac391be

@teebszet teebszet changed the title Chore/trigger npm publish on pr merge chore/trigger npm publish on pr merge Dec 7, 2023
@teebszet teebszet changed the title chore/trigger npm publish on pr merge chore: trigger npm publish on pr merge Dec 7, 2023
Copy link
Member

@victorkirov victorkirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@teebszet teebszet merged commit 086ebbb into develop Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants