Show cenotaph warning (#219)

* Show cenotaph warning * Move cenotaph warning to transactionSummary
secretkeylabs · Apr 23, 2024 · 74fe75e · 74fe75e
1 parent 1250117
commit 74fe75e
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 30 deletions.
diff --git a/src/app/components/confirmBtcTransaction/index.tsx b/src/app/components/confirmBtcTransaction/index.tsx
@@ -48,6 +48,7 @@ type Props = {
   outputs: btcTransaction.EnhancedOutput[];
   feeOutput?: btcTransaction.TransactionFeeOutput;
   runeSummary?: RuneSummary;
+  showCenotaphCallout: boolean;
   isLoading: boolean;
   isSubmitting: boolean;
   isBroadcast?: boolean;
@@ -76,6 +77,7 @@ function ConfirmBtcTransaction({
   outputs,
   feeOutput,
   runeSummary,
+  showCenotaphCallout,
   isLoading,
   isSubmitting,
   isBroadcast,
@@ -205,6 +207,7 @@ function ConfirmBtcTransaction({
           outputs={outputs}
           feeOutput={feeOutput}
           isPartialTransaction={isPartialTransaction}
+          showCenotaphCallout={showCenotaphCallout}
           getFeeForFeeRate={getFeeForFeeRate}
           onFeeRateSet={onFeeRateSet}
           feeRate={feeRate}

diff --git a/src/app/components/confirmBtcTransaction/transactionSummary.tsx b/src/app/components/confirmBtcTransaction/transactionSummary.tsx
@@ -34,6 +34,7 @@ const WarningCallout = styled(Callout)`
 
 type Props = {
   isPartialTransaction: boolean;
+  showCenotaphCallout: boolean;
   inputs: btcTransaction.EnhancedInput[];
   outputs: btcTransaction.EnhancedOutput[];
   feeOutput?: btcTransaction.TransactionFeeOutput;
@@ -49,6 +50,7 @@ type Props = {
 
 function TransactionSummary({
   isPartialTransaction,
+  showCenotaphCallout,
   inputs,
   outputs,
   feeOutput,
@@ -127,6 +129,9 @@ function TransactionSummary({
       {isUnConfirmedInput && (
         <WarningCallout bodyText={t('UNCONFIRMED_UTXO_WARNING')} variant="warning" />
       )}
+      {showCenotaphCallout && (
+        <WarningCallout variant="danger" bodyText={t('RUNES_CENOTAPH_WARNING')} />
+      )}
       {runeSummary?.mint && !runeSummary?.mint?.runeIsOpen && (
         <WarningCallout bodyText={t('RUNE_TERM_ENDED')} variant="danger" />
       )}

diff --git a/src/app/screens/confirmBtcTransaction/index.tsx b/src/app/screens/confirmBtcTransaction/index.tsx
@@ -242,7 +242,7 @@ function ConfirmBtcTransaction() {
           description={t('BTC_TRANSFER_DANGER_ALERT_DESC')}
           buttonText={t('BACK')}
           onClose={onClosePress}
-          secondButtonText={t('CONITNUE')}
+          secondButtonText={t('CONTINUE')}
           onButtonClick={onClosePress}
           onSecondButtonClick={onContinueButtonClick}
           isWarningAlert

diff --git a/src/app/screens/confirmInscriptionRequest/index.tsx b/src/app/screens/confirmInscriptionRequest/index.tsx
@@ -344,7 +344,7 @@ function ConfirmInscriptionRequest() {
           description={t('CONFIRM_TRANSACTION.BTC_TRANSFER_DANGER_ALERT_DESC')}
           buttonText={t('CONFIRM_TRANSACTION.BACK')}
           onClose={onClosePress}
-          secondButtonText={t('CONITNUE')}
+          secondButtonText={t('CONTINUE')}
           onButtonClick={onClosePress}
           onSecondButtonClick={onContinueButtonClick}
           isWarningAlert

diff --git a/src/app/screens/restoreFunds/recoverRunes/index.tsx b/src/app/screens/restoreFunds/recoverRunes/index.tsx
@@ -176,6 +176,7 @@ function RecoverRunes() {
         inputs={summary?.inputs ?? []}
         outputs={summary?.outputs ?? []}
         feeOutput={summary?.feeOutput}
+        showCenotaphCallout={!!summary?.runeOp?.Cenotaph?.flaws}
         runeSummary={runeSummary}
         isLoading={isLoading}
         isSubmitting={isBroadcasting}

diff --git a/src/app/screens/sendBtc/stepDisplay.tsx b/src/app/screens/sendBtc/stepDisplay.tsx
@@ -125,6 +125,7 @@ function StepDisplay({
           inputs={summary.inputs}
           outputs={summary.outputs}
           feeOutput={summary.feeOutput}
+          showCenotaphCallout={!!summary?.runeOp?.Cenotaph?.flaws}
           isLoading={false}
           confirmText={t('COMMON.CONFIRM')}
           cancelText={t('COMMON.CANCEL')}

diff --git a/src/app/screens/sendRune/stepDisplay.tsx b/src/app/screens/sendRune/stepDisplay.tsx
@@ -131,6 +131,7 @@ function StepDisplay({
           inputs={summary.inputs}
           outputs={summary.outputs}
           feeOutput={summary.feeOutput}
+          showCenotaphCallout={!!summary?.runeOp?.Cenotaph?.flaws}
           runeSummary={runeSummary}
           isLoading={false}
           confirmText={t('COMMON.CONFIRM')}

diff --git a/src/app/screens/signBatchPsbtRequest/index.tsx b/src/app/screens/signBatchPsbtRequest/index.tsx
@@ -124,12 +124,8 @@ interface TxResponse {
   psbtBase64: string;
 }
 
-type PsbtSummary = {
-  inputs: btcTransaction.EnhancedInput[];
-  outputs: btcTransaction.EnhancedOutput[];
-  feeOutput?: btcTransaction.TransactionFeeOutput | undefined;
-  hasSigHashNone: boolean;
-};
+// TODO: export this from core
+type PsbtSummary = Awaited<ReturnType<btcTransaction.EnhancedPsbt['getSummary']>>;
 
 function SignBatchPsbtRequest() {
   const { btcAddress, ordinalsAddress, selectedAccount, network } = useWalletSelector();
@@ -434,6 +430,9 @@ function SignBatchPsbtRequest() {
                 feeOutput={parsedPsbts[currentPsbtIndex].summary.feeOutput}
                 runeSummary={parsedPsbts[currentPsbtIndex].runeSummary}
                 isPartialTransaction={!parsedPsbts[currentPsbtIndex].summary.feeOutput}
+                showCenotaphCallout={
+                  !!parsedPsbts[currentPsbtIndex].summary.runeOp?.Cenotaph?.flaws
+                }
               />
             )}
           </CustomizedModalContainer>

diff --git a/src/app/screens/signPsbtRequest/index.tsx b/src/app/screens/signPsbtRequest/index.tsx
@@ -1,7 +1,6 @@
 import { makeRPCError, sendRpcResponse } from '@common/utils/rpc/helpers';
 import ConfirmBitcoinTransaction from '@components/confirmBtcTransaction';
 import RequestError from '@components/requests/requestError';
-import useBtcClient from '@hooks/useBtcClient';
 import useHasFeature from '@hooks/useHasFeature';
 import useTransactionContext from '@hooks/useTransactionContext';
 import useWalletSelector from '@hooks/useWalletSelector';
@@ -18,6 +17,9 @@ import { RpcErrorCode } from 'sats-connect';
 import useSignPsbt from './useSignPsbt';
 import useSignPsbtValidationGate from './useSignPsbtValidationGate';
 
+// TODO: export this from core
+type PSBTSummary = Awaited<ReturnType<btcTransaction.EnhancedPsbt['getSummary']>>;
+
 function SignPsbtRequest() {
   const navigate = useNavigate();
 
@@ -26,10 +28,7 @@ function SignPsbtRequest() {
 
   const [isLoading, setIsLoading] = useState(true);
   const [isSigning, setIsSigning] = useState(false);
-  const [inputs, setInputs] = useState<btcTransaction.EnhancedInput[]>([]);
-  const [outputs, setOutputs] = useState<btcTransaction.EnhancedOutput[]>([]);
-  const [feeOutput, setFeeOutput] = useState<btcTransaction.TransactionFeeOutput | undefined>();
-  const [hasSigHashNone, setHasSigHashNone] = useState(false);
+  const [summary, setSummary] = useState<PSBTSummary | undefined>();
   const [runeSummary, setRuneSummary] = useState<RuneSummary | undefined>(undefined);
   const hasRunesSupport = useHasFeature('RUNES_SUPPORT');
 
@@ -49,19 +48,10 @@ function SignPsbtRequest() {
 
     parsedPsbt
       .getSummary()
-      .then(async (summary) => {
-        const {
-          feeOutput: psbtFeeOutput,
-          inputs: psbtInputs,
-          outputs: psbtOutputs,
-          hasSigHashNone: psbtHasSigHashNone,
-        } = summary;
-        setFeeOutput(psbtFeeOutput);
-        setInputs(psbtInputs);
-        setOutputs(psbtOutputs);
-        setHasSigHashNone(psbtHasSigHashNone);
+      .then(async (txSummary) => {
+        setSummary(txSummary);
         if (hasRunesSupport) {
-          setRuneSummary(await parseSummaryForRunes(txnContext, summary, network.type));
+          setRuneSummary(await parseSummaryForRunes(txnContext, txSummary, network.type));
         }
         setIsLoading(false);
       })
@@ -138,14 +128,15 @@ function SignPsbtRequest() {
     />
   ) : (
     <ConfirmBitcoinTransaction
-      inputs={inputs}
-      outputs={outputs}
-      feeOutput={feeOutput}
+      inputs={summary?.inputs ?? []}
+      outputs={summary?.outputs ?? []}
+      feeOutput={summary?.feeOutput}
+      showCenotaphCallout={!!summary?.runeOp?.Cenotaph?.flaws}
       runeSummary={runeSummary}
       isLoading={isLoading}
       isSubmitting={isSigning}
       isBroadcast={payload.broadcast}
-      hasSigHashNone={hasSigHashNone}
+      hasSigHashNone={summary?.hasSigHashNone}
       confirmText={t('CONFIRM')}
       cancelText={t('CANCEL')}
       onCancel={onCancel}

diff --git a/src/locales/en.json b/src/locales/en.json
@@ -374,10 +374,11 @@
     "ORDINAL_DETECTED_ACTION": "Move to my ordinals address",
     "BTC_TRANSFER_DANGER_ALERT_TITLE": "Danger",
     "BTC_TRANSFER_DANGER_ALERT_DESC": "You are about to make a Bitcoin transfer which contains an ordinal inscription. Once transferred out of the wallet, you will not be able to recover them.",
-    "CONITNUE": "Continue",
+    "CONTINUE": "Continue",
     "BACK": "Back",
     "HIGH_FEE_WARNING_TEXT": "The estimated transaction fee for this transaction is very high.",
     "UNCONFIRMED_BALANCE_WARNING": "You are spending unconfirmed outputs in this transaction. This may lower the effective fee rate causing delays in transaction confirmation",
+    "RUNES_CENOTAPH_WARNING": "This transaction will burn all input Runes. Make sure you trust the requesting app.",
     "LEDGER": {
       "CONNECT": {
         "TITLE": "Connect your hardware wallet",