Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed Transaction icon #155

Closed
m-aboelenein opened this issue Dec 19, 2022 · 0 comments
Closed

Failed Transaction icon #155

m-aboelenein opened this issue Dec 19, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@m-aboelenein
Copy link
Member

Severity

  • Trivial (Some UI issue)

Summary

when a transaction fails it should show the failure icon instead of the default icon of the tx

Reproduce steps

  1. send a tx that is expected to fail
  2. confirm the tx
  3. open the coin dashboard of the failed tx coin

Expected result

transaction shows with the failed icon

Actual result

transaction appears with the default icon for the tx

@m-aboelenein m-aboelenein added the bug Something isn't working label Dec 19, 2022
@m-aboelenein m-aboelenein added this to the Sprint 23 - Dec 30 milestone Dec 19, 2022
@yknl yknl closed this as completed Aug 24, 2023
teebszet added a commit that referenced this issue Apr 10, 2024
* chore: add a script for merging public to private

chore: update merge scripts

chore: update scripts with correct remote url

chore: fix gh cli check in scirpts

chore: fix scripts with pr command

chore: fix new lines

chore: fix attempt for the release pr action error: fatal unrelated histories

chore: add workflow to trigger the script

chore: remove trigger on pr

chore: rename workflow and add choice of direction

chore: update script with --unshallow

chore: remove --unshallow

chore: simplify merge script

chore: delete other script in favour of one way merges

chore: continue script if bad tags

chore: assign reviewers to the merge

chore: fix assign reviewer part

chore: oops remove merge markers

chore: loop for main and develop

chore: add script use to workflows

chore: remove unshallow for --allow-unrelated-histories

chore: remove comment

* chore: use a generic name for merge script

* chore: add CODEOWNERS file

* chore: fix asset upload and add steps to copy release to public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants