Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-fixes/ Show seedphrase and type seedphrase screens #59

Closed
5 of 9 tasks
QUDBS opened this issue Nov 14, 2022 · 2 comments · Fixed by #85
Closed
5 of 9 tasks

ui-fixes/ Show seedphrase and type seedphrase screens #59

QUDBS opened this issue Nov 14, 2022 · 2 comments · Fixed by #85
Assignees
Labels

Comments

@QUDBS
Copy link

QUDBS commented Nov 14, 2022

Show seedphrase screens

Screenshot 2022-11-14 at 17 49 43

Screenshot 2022-11-14 at 17 51 37

  • make the ordinal numbers next to words less prominent (white with 60% opacity)
  • issue with longer words going on 2 lines / can be seen with @QUDBS

Type seedphrase screens

Screenshot 2022-11-14 at 18 03 15

Screenshot 2022-11-14 at 18 10 30

  • Border of the field should be red too, #D33C3C 30% opacity

Screenshot 2022-11-15 at 13 45 42

- [ ] The type seedphrase screen on the Restore wallet flow is different (fonts, button position) than on the New wallet flow. They should be almost similar
@QUDBS QUDBS added this to the Sprint 21 - Nov 28 milestone Nov 14, 2022
@QUDBS
Copy link
Author

QUDBS commented Nov 14, 2022

Having a doubt right now. Should the field name be "Selected words" or "Seedphrase" ?

@QUDBS QUDBS added invalid This doesn't seem right ui labels Nov 15, 2022
@QUDBS
Copy link
Author

QUDBS commented Nov 18, 2022

Screenshot 2022-11-18 at 11 23 51

Regarding the seedwords length problem, I edited the dimensions on this component.
Given that the longest seed words can go up to 8 letters and that the longest letter is M, I retested with words like "Maximum, Mushroom, Mosquito" and there should be enough space for at least an extra character on each line

@QUDBS QUDBS removed the invalid This doesn't seem right label Nov 21, 2022
@QUDBS QUDBS mentioned this issue Nov 23, 2022
31 tasks
@Imamah-Zafar Imamah-Zafar linked a pull request Nov 24, 2022 that will close this issue
8 tasks
@DuskaT021 DuskaT021 reopened this Dec 5, 2022
teebszet pushed a commit that referenced this issue Nov 29, 2023
…screen (#59)

* feat: tweak rare sats bundle screen to support new satributes

* feat: add v2 of useGetUtxoOrdinalBundle and use it in ordinal detail screen

* feat: add sattributes to ordinal details screen (#60)

* chore: remove glow from RareSatIcon component

* feat: add sattributes to ordinal details screen

---------

Co-authored-by: Abdul Haseeb <haseeb4239@gmail.com>

---------

Co-authored-by: Abdul Haseeb <haseeb4239@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants