Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

longer words in the seedphrase alignment #81

Closed
DuskaT021 opened this issue Nov 23, 2022 · 1 comment · Fixed by #85
Closed

longer words in the seedphrase alignment #81

DuskaT021 opened this issue Nov 23, 2022 · 1 comment · Fixed by #85
Assignees
Labels
bug Something isn't working

Comments

@DuskaT021
Copy link
Contributor

DuskaT021 commented Nov 23, 2022

Component

web-extension - latest develop backup wallet screen
image

Severity

Choose one:

  • Trivial (Some UI issue)

Summary

Longer words get misaligned in the next row on the Backup wallet screen

Reproduce steps

  1. Go to settings
  2. Click Backup wallet

Expected result

Words should be aligned in the same row.

Actual result

misalignment of the words in the seedphrase

Remark

Visually a problem especially when using seedphrase with 24 words.
If this is already included in the UI fixes I'll close the issue.

@DuskaT021 DuskaT021 added the bug Something isn't working label Nov 23, 2022
@DuskaT021 DuskaT021 added this to the Sprint 21 - Nov 28 milestone Nov 23, 2022
@Imamah-Zafar Imamah-Zafar linked a pull request Nov 24, 2022 that will close this issue
8 tasks
@yknl yknl assigned Imamah-Zafar and DuskaT021 and unassigned Imamah-Zafar Nov 28, 2022
@DuskaT021
Copy link
Contributor Author

Fixed @Imamah-Zafar

teebszet added a commit that referenced this issue Mar 14, 2024
* feat: init structure for send rune flow with flag for testnet only

* add hook

* add runes api client

* feat: handle rune token display on home and token dashboard (#81)

* wip

* chore: tweak token dashboard for runes and add tokens to home send bottomsheet

* remove TODOs that are handled now

* touchup

* chore: update text to support runes in receive screen

* chore: dry

* chore: remove runes list from client store

* chore: remvoe todos related to texts

* chore: remove useGetRuneFungibleTokens config todo

---------

Co-authored-by: fede erbes <fedeerbes@gmail.com>

* Manage tokens screen for runes support (#84)

* refactor key variables to improve readability

* updates

* major refactor stx coinslist & support runes in manage token page for testnet

* remove conditonals and improve performance

* add figma for mainnet coming soon

* chore: add protocol icons for stacks, brc20 and runes tokens (#83)

* chore: add protocol icons for stacks, brc20 and runes tokens

* fix: token image loader and clean render logic

* chore: use our runes logo and remove square styles

* chore: use a default size const

* fix: font size and add missing protocol to brc20 tokens

* updates

* fix stx icon issue

---------

Co-authored-by: Terence Ng <ngtere@live.com.sg>

* standardize currency typing and improve variable namings

* revert logic + touchup

* touchup

* add rune icon

* add typing

* rename variable

* progress

* progress

* fix button disabled

* fix amount validations and display error msg

* chore: use core pr version with runes support

* Tim/eng 3814 receive runes screen design check (#91)

* fix: receive bottom sheet icons and blur

* Update en.json

Co-authored-by: Terence Ng <terence.ng@cakedefi.com>

---------

Co-authored-by: Terence Ng <terence.ng@cakedefi.com>

* nits

* Terence/fix edge case renderings (#95)

* fix (#94)

* fix

* Update src/app/ui-library/input.tsx

Co-authored-by: Tim Man <tim@secretkeylabs.com>

* fix

* use variant

* use brc

* fix expression readability

* fix sip coins which are hidden by manage token list should not be sendable in send coins list (#96)

* update key

* fix: remove unused route

* fix: coin dashboard should show names and no protocol if none

* standardize ticker icon for no image tickers

* remove deprecated usage

* Update src/locales/en.json

* Update src/locales/en.json

* Update src/locales/en.json

* Update src/locales/en.json

* Update src/locales/en.json

* fix up logic

* refactor: manage tokens for runes (#98)

* refactor: manage tokens for runes

* fix: be more strict on toggle handler

* chore: minor cleanup

* chore: minor diff clean up

* update remaining FT to sip-10

* testing (#93)

* touchup currencyTypes logic to go back to using FT, fixes, prepare improved receive screen for STX, BTC, ORD

* update receive coin screen to handle STX & BTC

* fix type issue

* revert console log

* revert changes

* logic fix

* remove unused component

* Tim/refactor manage tokens (#99)

* refactor: brc20 and sip10 tokens should use react-query hooks

and no longer store balances in redux

* fix: define a redux migration callback to keep user settings for manage tokens

* fix: brc20 ft list merge

* update remaining FT to sip-10

* testing (#93)

* touchup currencyTypes logic to go back to using FT, fixes, prepare improved receive screen for STX, BTC, ORD

* update receive coin screen to handle STX & BTC

* fix type issue

* refactor: brc20 and sip10 tokens should use react-query hooks

and no longer store balances in redux

* test

* revert

* fix: also remove coins from redux state in migration

* chore: consistent naming

---------

Co-authored-by: Terence Ng <ngtere@live.com.sg>
Co-authored-by: Terence Ng <terence.ng@cakedefi.com>

* fix: fix typing and null case for redux migration function

* chore: bump to latest beta core

* refactorings

* typo

* use bigint and fix amount precision

* fix debounce

* update core

* remove script info

* chore: bump core version

* hack: update confirmTransaction to handle runes v1

* allow display input/output

* revert runes icon to use square

* chore: core version with undefined runes fix

* additional check

* update logo

* Empty rune list message scenario and error message (#107)

* feat: init structure for send rune flow with flag for testnet only

* add hook

* add runes api client

* feat: handle rune token display on home and token dashboard (#81)

* wip

* chore: tweak token dashboard for runes and add tokens to home send bottomsheet

* remove TODOs that are handled now

* touchup

* chore: update text to support runes in receive screen

* chore: dry

* chore: remove runes list from client store

* chore: remvoe todos related to texts

* chore: remove useGetRuneFungibleTokens config todo

---------

Co-authored-by: fede erbes <fedeerbes@gmail.com>

* Manage tokens screen for runes support (#84)

* refactor key variables to improve readability

* updates

* major refactor stx coinslist & support runes in manage token page for testnet

* remove conditonals and improve performance

* add figma for mainnet coming soon

* chore: add protocol icons for stacks, brc20 and runes tokens (#83)

* chore: add protocol icons for stacks, brc20 and runes tokens

* fix: token image loader and clean render logic

* chore: use our runes logo and remove square styles

* chore: use a default size const

* fix: font size and add missing protocol to brc20 tokens

* updates

* fix stx icon issue

---------

Co-authored-by: Terence Ng <ngtere@live.com.sg>

* standardize currency typing and improve variable namings

* revert logic + touchup

* touchup

* add rune icon

* add typing

* rename variable

* progress

* progress

* chore: use core pr version with runes support

* fix button disabled

* fix amount validations and display error msg

* Tim/eng 3814 receive runes screen design check (#91)

* fix: receive bottom sheet icons and blur

* Update en.json

Co-authored-by: Terence Ng <terence.ng@cakedefi.com>

---------

Co-authored-by: Terence Ng <terence.ng@cakedefi.com>

* nits

* fix (#94)

* Terence/fix edge case renderings (#95)

* fix (#94)

* fix

* Update src/app/ui-library/input.tsx

Co-authored-by: Tim Man <tim@secretkeylabs.com>

* fix

* use variant

* use brc

* fix expression readability

* fix sip coins which are hidden by manage token list should not be sendable in send coins list (#96)

* update key

* fix: remove unused route

* fix: coin dashboard should show names and no protocol if none

* standardize ticker icon for no image tickers

* remove deprecated usage

* Update src/locales/en.json

* Update src/locales/en.json

* Update src/locales/en.json

* Update src/locales/en.json

* Update src/locales/en.json

* fix up logic

* refactor: manage tokens for runes (#98)

* refactor: manage tokens for runes

* fix: be more strict on toggle handler

* chore: minor cleanup

* chore: minor diff clean up

* update remaining FT to sip-10

* testing (#93)

* touchup currencyTypes logic to go back to using FT, fixes, prepare improved receive screen for STX, BTC, ORD

* update receive coin screen to handle STX & BTC

* fix type issue

* revert console log

* revert changes

* logic fix

* remove unused component

* Tim/refactor manage tokens (#99)

* refactor: brc20 and sip10 tokens should use react-query hooks

and no longer store balances in redux

* fix: define a redux migration callback to keep user settings for manage tokens

* fix: brc20 ft list merge

* update remaining FT to sip-10

* testing (#93)

* touchup currencyTypes logic to go back to using FT, fixes, prepare improved receive screen for STX, BTC, ORD

* update receive coin screen to handle STX & BTC

* fix type issue

* refactor: brc20 and sip10 tokens should use react-query hooks

and no longer store balances in redux

* test

* revert

* fix: also remove coins from redux state in migration

* chore: consistent naming

---------

Co-authored-by: Terence Ng <ngtere@live.com.sg>
Co-authored-by: Terence Ng <terence.ng@cakedefi.com>

* fix: fix typing and null case for redux migration function

* chore: bump to latest beta core

* refactorings

* typo

* use bigint and fix amount precision

* fix debounce

* update core

* remove script info

* chore: bump core version

* hack: update confirmTransaction to handle runes v1

* allow display input/output

* revert runes icon to use square

* chore: core version with undefined runes fix

* additional check

* update logo

* push

* push

---------

Co-authored-by: Tim Man <tim@secretkeylabs.com>
Co-authored-by: fede erbes <fedeerbes@gmail.com>
Co-authored-by: Victor Kirov <victor.kirov@gmail.com>

* update label

* fix: overflow on send rune amound input, when long balance (#105)

* fix: overflow on send rune amound input, when long balance

* refactor: move the complications to the input component file

* fix: set allowNegative=false to fix warnings for number format (#106)

* fix: set allowNegative=false to fix warnings for number format

* fix: styling of stx tx transaction history

* fix balance becoming exponential string for large digits

* fix large amount / decimal formatting

* touchup

* adjust gap to cater max scenario

* update display ellipsis for high digit/decimal values

* small fix

* fix: css balance token tile

* fix: cleaner css

---------

Co-authored-by: Terence Ng <ngtere@live.com.sg>

* fix (#109)

* [ENG-3193] refactor: Refactor away from selectedOrdinal (#791)

* commit changes

* remove selectedOrdinal for raresat screen

* update recover screens

* fix translation text

* revert non null assertion

* fix bug

* fix merge

* fix (#109)

* fixes (#110)

* fixes

* remove log

* disable rbf

* pull latest core to support rbf

* Update core and fix map key for txn history

---------

Co-authored-by: Victor Kirov <victor.kirov@gmail.com>

* [ENG-3193] refactor: Refactor away from selectedOrdinal (#791)

* commit changes

* remove selectedOrdinal for raresat screen

* update recover screens

* fix translation text

* revert non null assertion

* fix bug

* fix merge

* chore: bump core to v11.1.1 (#806)

* chore: Bump core to 11.1.2 (#807)

* chore: bump to latest beta core

* update lock

* use mobile values

* fix render

* Solve missing name

* Fallback for SIP-10 FungibleTokens with missing name

* chore: bump core to v11.3.0

---------

Co-authored-by: Terence Ng <ngtere@live.com.sg>
Co-authored-by: Terence Ng <terence.ng@cakedefi.com>
Co-authored-by: fede erbes <fedeerbes@gmail.com>
Co-authored-by: Victor Kirov <victor.kirov@gmail.com>
Co-authored-by: jordankzf <jordan@secretkeylabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants