Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seedphrase screen #211

Merged
merged 5 commits into from
Jan 30, 2023
Merged

fix: seedphrase screen #211

merged 5 commits into from
Jan 30, 2023

Conversation

Imamah-Zafar
Copy link
Contributor

@Imamah-Zafar Imamah-Zafar commented Jan 20, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

(Optional) Resolved: #205

What is the new behavior?

Includes component spec effects added in https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=1068%3A48482&t=9xX1k7M2qMw2dehm-0
fixes ui bugs in input seedphrase screen

@Imamah-Zafar Imamah-Zafar linked an issue Jan 20, 2023 that may be closed by this pull request
4 tasks
@Imamah-Zafar Imamah-Zafar self-assigned this Jan 20, 2023
@DuskaT021 DuskaT021 added the bug Something isn't working label Jan 21, 2023
@DuskaT021 DuskaT021 added this to the Sprint 25 - Jan 30 milestone Jan 21, 2023
}
:active {
opacity: 0.6;
background: #3A3D5E;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colors should be fetched from the theme, @QUDBS can you tell us a name for that color token so we can add to the theme file?

@m-aboelenein
Copy link
Member

@Imamah-Zafar can you replace the colors in this pr with the theme tokens we are undergoing a re-branding soon and we don't want to update components individually

@yknl yknl merged commit e51142e into develop Jan 30, 2023
teebszet pushed a commit that referenced this pull request May 31, 2024
…-with-core

chore/replace-sats-connect-with-core & Support `runes_getBalance`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui fixes/ Seedphrase screen
4 participants