Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix minor ui issues #252

Merged
merged 3 commits into from
Feb 16, 2023
Merged

fix minor ui issues #252

merged 3 commits into from
Feb 16, 2023

Conversation

Imamah-Zafar
Copy link
Contributor

@Imamah-Zafar Imamah-Zafar commented Feb 15, 2023 •
edited by DuskaT021
Loading

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

(Optional) Resolved: #238 #234 #244 #246 #248

What is the new behavior?

Screenshot / Video

hover.mov
ui-issue.mov

This was linked to issues Feb 15, 2023
Ordinals activation alert copy change #251
Closed
Different hover states in home screen #250
Closed
Bitcoin QR code screen copy address button cut off #249
Closed
Buttons stuck in pressed/highlight state #248
Closed
Copy wallet address needs a toast #246
Closed
Transaction history highlight issue #238
Closed
UI issue in onboarding flow password input screen #244
Closed
@Imamah-Zafar Imamah-Zafar self-assigned this Feb 15, 2023
@Imamah-Zafar Imamah-Zafar added this to the Sprint 27 - Feb 27 milestone Feb 15, 2023
@Imamah-Zafar Imamah-Zafar linked an issue Feb 15, 2023 that may be closed by this pull request
Wallet window doesn't close after transaction broadcast #234
Closed
@DuskaT021 DuskaT021 added the bug Something isn't working label Feb 15, 2023
@DuskaT021
Copy link
Contributor

This is tested 👍

@DuskaT021 DuskaT021 self-requested a review February 15, 2023 14:00
DuskaT021
DuskaT021 previously approved these changes Feb 15, 2023
View reviewed changes
@yknl yknl merged commit 33aa3ee into develop Feb 16, 2023
@m-aboelenein m-aboelenein deleted the imamahzafar/ui/fix branch February 17, 2023 10:03
dhriaznov added a commit that referenced this pull request May 16, 2024
@dhriaznov
[ENG-4278] fix: Recipient address is required validation error when t…
af3c46a 
…he input value is set (#252)

* [ENG-4278] fix: Recipient address is required validation error when the input value is set

* Remove the unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yknl yknl yknl approved these changes

@DuskaT021 DuskaT021 DuskaT021 left review comments

Assignees

@Imamah-Zafar Imamah-Zafar

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 27 - Feb 27
3 participants
@Imamah-Zafar @DuskaT021 @yknl