Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update STX confirmation screen UI #296

Merged
merged 15 commits into from
Apr 27, 2023
Merged

Conversation

Imamah-Zafar
Copy link
Contributor

@Imamah-Zafar Imamah-Zafar commented Mar 14, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

(Optional) Resolved: #291

What is the new behavior?

Screenshot / Video

Updated screens

STX Transfer Transaction Screen:
stx

NFT Transfer Transaction Screen:

nft.mov

FT Transfer transaction Screen:
ft

Contract Call Transaction Screen, Message Signing screen and Contract Deploy Transaction Screen:

browser-tx.mov

@Imamah-Zafar Imamah-Zafar marked this pull request as ready for review April 11, 2023 06:14
@Imamah-Zafar Imamah-Zafar linked an issue Apr 11, 2023 that may be closed by this pull request
@Imamah-Zafar Imamah-Zafar added this to the Sprint 30 - April 10 milestone Apr 11, 2023
@Imamah-Zafar Imamah-Zafar added enhancement New feature or request ui labels Apr 11, 2023
@Imamah-Zafar Imamah-Zafar self-assigned this Apr 11, 2023
m-aboelenein
m-aboelenein previously approved these changes Apr 25, 2023
@DuskaT021
Copy link
Contributor

Missing Signing with field in the Sign Message screen:

figma link: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=133-19799&t=mmMuaC0idO1aVvry-0

left image is figma, right image is branch

image

@DuskaT021
Copy link
Contributor

DuskaT021 commented Apr 25, 2023

Missing copy action in the copy button for all the tokens, except the btc and stx

link to figma: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=1068-48480&t=tN7Sz7fuo799brm9-0

image

@DuskaT021
Copy link
Contributor

DuskaT021 commented Apr 25, 2023

Connecting to gamma.io and purchasing an nft ( tx id )left is the branch and on the right is the figma design

Hey @QUDBS is this link the latest reference to the screen when buying an nft from gamma.io? Thank you

link to figma: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=133-19799&t=mmMuaC0idO1aVvry-0

Screen.Recording.2023-04-25.at.21.10.52.mov

@m-aboelenein
Copy link
Member

Missing Signing with field in the Sign Message screen:

figma link: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=133-19799&t=mmMuaC0idO1aVvry-0

left image is figma, right image is branch

image

This is a separate issue that will be implemented along with bitcoin message signing
#367

@QUDBS
Copy link

QUDBS commented Apr 26, 2023

Connecting to gamma.io and purchasing an nft ( tx id )left is the branch and on the right is the figma design

Hey @QUDBS is this link the latest reference to the screen when buying an nft from gamma.io? Thank you

link to figma: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=133-19799&t=mmMuaC0idO1aVvry-0

Screen.Recording.2023-04-25.at.21.10.52.mov

Not sure which figma screen you are lnking to: the good one is here https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=3657%3A127906&t=H08Fh8ifbMePEXoW-1

@DuskaT021
Copy link
Contributor

Connecting to gamma.io and purchasing an nft ( tx id )left is the branch and on the right is the figma design
Hey @QUDBS is this link the latest reference to the screen when buying an nft from gamma.io? Thank you
link to figma: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=133-19799&t=mmMuaC0idO1aVvry-0
Screen.Recording.2023-04-25.at.21.10.52.mov

Not sure which figma screen you are lnking to: the good one is here https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=3657%3A127906&t=H08Fh8ifbMePEXoW-1

Okay I used the correct one, thanks for double checking @QUDBS :)

@Imamah-Zafar
Copy link
Contributor Author

Imamah-Zafar commented Apr 26, 2023

Missing copy action in the copy button for all the tokens, except the btc and stx

link to figma: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=1068-48480&t=tN7Sz7fuo799brm9-0

image

a separate issue can be opened for this since this would be on develop as well . the coin dashboard screens were not modified in this screen. issue

@Imamah-Zafar
Copy link
Contributor Author

Imamah-Zafar commented Apr 26, 2023

Connecting to gamma.io and purchasing an nft ( tx id )left is the branch and on the right is the figma design

Hey @QUDBS is this link the latest reference to the screen when buying an nft from gamma.io? Thank you

link to figma: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=133-19799&t=mmMuaC0idO1aVvry-0

Screen.Recording.2023-04-25.at.21.10.52.mov

the layout issue has been fixed. the copy depends on the post condition and can vary from the figma file. As for the total card this also depends on the type of transaction being made. the total card will show up for transactions which have amount value in their transaction payload since the payload is used to show all information in ui. For transactions that dont have the amount payload such as purchasing nft transactions the total card isnt shown.
total

@Imamah-Zafar Imamah-Zafar merged commit ad4d0fd into develop Apr 27, 2023
@Imamah-Zafar Imamah-Zafar deleted the imamahzafar/feat/stx-tx-screen branch April 27, 2023 13:25
teebszet pushed a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ui enhancement/ update STX confirm transaction screens
5 participants