-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transaction settings screen UI #383
Update transaction settings screen UI #383
Conversation
…-extension into imamahzafar/feat/update-transaction-settings-screen
the latest commit has the fix for issue 384 ordinal-send.mov |
…-extension into imamahzafar/feat/update-transaction-settings-screen
Just a question, [this is on prod as well] Scenario: when the fee amount is changed from default to fast for example, is it expected, when I reopen the advanced settings for the regular button to be active? Should't the lastly used button, be active - in my case it was fast button? Screen.Recording.2023-05-04.at.23.52.36.mov |
when clearing the fee amount input (btc transactions and ordinal transactions) and hitting apply the NaN value is displayed. We should handle it similarly like we do for stx transactions, which is if the input is cleared it should fallback to default or to display an error message. Screen.Recording.2023-05-05.at.00.09.44.mov |
#358 |
you're right. the experience can be made better by storing the state. we can create an issue for this and deal it along with issue #358 |
This can be merged. |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
(Optional) Resolved: #376
What is the new behavior?
The transaction setting screens have been updated according to the new UI
Screenshot / Video
Modifying Btc fee
BTC-EDIT-FEE.mov
Modifying Nft fee
nft-edit-fees.mov
Modifying Nonce
nonce.mov