fix: wallet sync non-vanilla objects failure #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-2265 wallet data loading issue
When Switching accounts initially the wallet balances are not shown until you select the same account again |
m-aboelenein
approved these changes
Jun 16, 2023
|
This is tested and can be merged 👍 |
m-aboelenein
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
(Optional) Resolved: ENG-2265
If more than one chrome window is open and both windows have the XVerse popup open, then we sync the entire state between them, causing some objects to not deserialise properly. This causes issues when we try to use class obejcts that deserialised into native JS objects. This was evident in the balances shown in the home screen.
What is the new behavior?
We only sync the required bits of the store, so we don't end up with invalid objects in our store.