Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add guard for import ledger page #495

Merged
merged 2 commits into from
Jul 1, 2023
Merged

feat: add guard for import ledger page #495

merged 2 commits into from
Jul 1, 2023

Conversation

victorkirov
Copy link
Member

πŸ”˜ PR Type

What kind of change does this PR introduce?

  • Enhancement

πŸ“œ Background

We want to prevent the import ledger screen from being open more than once. We do this by closing any open import ledger tabs when a new one opens, similar to onboarding.

Issue Link: #ENG-2340

πŸ”„ Changes

  • Single tab guard was moved to its own component and used in the import ledger route, the onboarding guard, and the reset wallet guard
  • When a wallet is reset, we now close all tabs

To be tested:

  • Onboarding flow should be retested to ensure single tabs still work as expected
  • Import ledger flow needs to be tested for single tabs
  • We now close all open tabs when locking or resetting the wallet

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@victorkirov victorkirov changed the base branch from develop to ledger-btc-mvp June 30, 2023 15:03
@victorkirov victorkirov marked this pull request as ready for review June 30, 2023 15:03
@victorkirov victorkirov changed the title Vic/guards feat: add guard for import ledger page Jun 30, 2023
Copy link
Contributor

@dhriaznov dhriaznov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yknl yknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well.

@yknl yknl merged commit 1d8f713 into ledger-btc-mvp Jul 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants