Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim/ledger UI fixes #496

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Tim/ledger UI fixes #496

merged 3 commits into from
Jul 3, 2023

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 3, 2023

πŸ”˜ PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

πŸ“œ Background

Ledger Send BTC flow opens in a separate tab

If user opens popup and switches account, while tab is open, we want to reset the user flow for sending BTC

Issue Link: https://linear.app/xverseapp/issue/ENG-2325/account-switching-mid-ledger-send-flow
Context Link (if applicable):

πŸ”„ Changes

  • turn state sync on between tabs for the redux action: SelectAccount and SetShouldResetUserFlow
  • listen to shouldResetUserFlow flag and reset the send-btc flow (for ledger) when user switches account

πŸ–Ό Screenshot / πŸ“Ή Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

and trigger it when switching accounts to force send-btc user flow back to
beginning with cleared ui state
@teebszet teebszet changed the base branch from develop to ledger-btc-mvp July 3, 2023 09:19
@teebszet teebszet requested a review from dhriaznov July 3, 2023 09:19
@dhriaznov
Copy link
Contributor

Looks good, thanks! I think we should also add this logic for the ordinal sending flow

@teebszet
Copy link
Member Author

teebszet commented Jul 3, 2023

Looks good, thanks! I think we should also add this logic for the ordinal sending flow

yeah added a task here:
https://linear.app/xverseapp/issue/ENG-2345/account-switching-mid-ledger-send-ordinals-flow

@teebszet teebszet merged commit 73c2996 into ledger-btc-mvp Jul 3, 2023
@teebszet teebszet deleted the tim/ledger-ui-fixes branch November 23, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants