Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim/eng 2345 account switching mid ledger send ordinals flow #498

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 4, 2023

πŸ”˜ PR Type

What kind of change does this PR introduce?

  • redirect user back to nft dashboard if account switch is performed (via popup)

  • add a validation during send ordinal inscription to check ordinal is owned by active account

  • Bugfix

  • Enhancement

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no API changes)

  • Build related changes

  • CI related changes

  • Documentation content changes

  • Other... Please describe:

πŸ“œ Background

Issue Link: https://linear.app/xverseapp/issue/ENG-2345/account-switching-mid-ledger-send-ordinals-flow
Context Link (if applicable):

πŸ”„ Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

πŸ–Ό Screenshot / πŸ“Ή Video

Screen.Recording.2023-07-04.at.5.16.26.PM.mov

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@linear
Copy link

linear bot commented Jul 4, 2023

ENG-2345 Account switching mid Ledger send ordinals flow

Similar to ENG-2325, but for send ordinals:

see recording, there is another existing issue here, where

  • switching accounts from an ordinal detail screen doesn't change the send button
  • needs some more guidance on how this flow should look quentin

26b5953d-45de-4f0f-b628-5800ce7152fc

@teebszet teebszet changed the base branch from develop to ledger-btc-mvp July 4, 2023 09:28
@teebszet teebszet force-pushed the tim/eng-2345-account-switching-mid-ledger-send-ordinals-flow branch from a297c96 to 7646d4d Compare July 4, 2023 09:29
@teebszet teebszet requested a review from dhriaznov July 4, 2023 09:34
@teebszet teebszet merged commit 2aec43c into ledger-btc-mvp Jul 4, 2023
@teebszet teebszet deleted the tim/eng-2345-account-switching-mid-ledger-send-ordinals-flow branch July 4, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants