Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/release workflow #502

Merged
merged 28 commits into from
Jul 5, 2023
Merged

Chore/release workflow #502

merged 28 commits into from
Jul 5, 2023

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 5, 2023

πŸ”˜ PR Type

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

πŸ“œ Background

Previously the release workflow was failing for every release created here: https://github.com/secretkeylabs/xverse-web-extension/actions/workflows/release.yml?page=2

This PR fixes that workflow and the idea is so upload built release artifact to the releases page like here: https://github.com/secretkeylabs/xverse-web-extension/releases/tag/v0.13.0 (needs testing on next release)

This PR also saves the built output of each build workflow run, so that any tester can download the build directly from either the workflow run here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/5460899929
or as a comment on the PR (needs testing after merge)

Issue Link: https://linear.app/xverseapp/issue/ENG-2321/fix-release-workflow-for-web-extension
Context Link (if applicable):

πŸ”„ Changes

  • upload artifact from build workflow and attach as comment to PR
  • upload artifact from release workflow and upload to release url
  • fix webpack build issues from ubuntu (there was a casing error not detected when building with git checkout on MacOS)

Impact:

  • no impact on products
  • just easier for testing and release management

πŸ–Ό Screenshot / πŸ“Ή Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@teebszet teebszet requested a review from victorkirov July 5, 2023 10:41
@secretkeylabs secretkeylabs deleted a comment from github-actions bot Jul 5, 2023
Copy link
Member

@victorkirov victorkirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments for consideration.

webpack/webpack.config.js Outdated Show resolved Hide resolved
webpack/utils/build.js Show resolved Hide resolved
src/app/components/alertMessage/index.tsx Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/comment_pr.yml Outdated Show resolved Hide resolved
.github/workflows/comment_pr.yml Outdated Show resolved Hide resolved
.github/workflows/comment_pr.yml Outdated Show resolved Hide resolved
.github/workflows/comment_pr.yml Show resolved Hide resolved
@teebszet teebszet merged commit 5274882 into develop Jul 5, 2023
1 check passed
@teebszet teebszet deleted the chore/release-workflow branch July 5, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants