-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/release workflow #502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ac26726.
victorkirov
requested changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments for consideration.
victorkirov
approved these changes
Jul 5, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π PR Type
π Background
Previously the release workflow was failing for every release created here: https://github.com/secretkeylabs/xverse-web-extension/actions/workflows/release.yml?page=2
This PR fixes that workflow and the idea is so upload built release artifact to the releases page like here: https://github.com/secretkeylabs/xverse-web-extension/releases/tag/v0.13.0 (needs testing on next release)
This PR also saves the built output of each build workflow run, so that any tester can download the build directly from either the workflow run here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/5460899929
or as a comment on the PR (needs testing after merge)
Issue Link: https://linear.app/xverseapp/issue/ENG-2321/fix-release-workflow-for-web-extension
Context Link (if applicable):
π Changes
Impact:
πΌ Screenshot / πΉ Video
Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.
β Review checklist
Please ensure the following are true before merging: