Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim/eng 2384 user cant add the ledger account if they dont close the #511

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 10, 2023

πŸ”˜ PR Type

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

πŸ“œ Background

see ticket for repro steps:

Issue Link: https://linear.app/xverseapp/issue/ENG-2384/user-cant-add-the-ledger-account-if-they-dont-close-the-wallet-created
Context Link (if applicable):

πŸ”„ Changes

  • fix for the redux state sync across tabs/popup
    • to do with adding new accounts or adding ledger accounts
    • when the "Wallet Restored" or "Wallet Created" tab still open
    • or when any other tab which dispatches AddAccount or AddLedgerAccount actions are open

Impact:

  • any screen to do with adding accounts between tabs could be affected

πŸ–Ό Screenshot / πŸ“Ή Video

Screen.Recording.2023-07-10.at.5.49.55.PM.mov

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@linear
Copy link

linear bot commented Jul 10, 2023

ENG-2384 User can't add the ledger account if they don't close the Wallet Created screen or Wallet Restored screen

User can't add the ledger account if they don't close the Wallet Created screen or Wallet Restored screen

https://discord.com/channels/895889501560377364/1123617560932401203/1126885403526435038

https://discord.com/channels/895889501560377364/1123617560932401203/1126884284251250770

Steps in both flows:

*when you restore xverse wallet, but leave the wallet restored screen open(tab) and click the popup and click on the connect hardware wallet (it will open the a 2nd tab) after going through the add account steps in the browser and the ledger device, you will not be able to add the ledger account

when you create the xverse wallet, but leave the wallet created screen open(tab) and click the popup and click on the connect hardware wallet(it will open a second tab) after going through the add account steps in the browser and the ledger device, you will not be able to add the ledger account

- the first tab prevents the user to actually add the ledger account*

@teebszet teebszet changed the base branch from develop to ledger-btc-mvp July 10, 2023 09:57
@teebszet teebszet merged commit b9ce9ba into ledger-btc-mvp Jul 10, 2023
@teebszet teebszet removed the request for review from Imamah-Zafar July 10, 2023 10:20
@m-aboelenein m-aboelenein deleted the tim/eng-2384-user-cant-add-the-ledger-account-if-they-dont-close-the branch July 10, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants