Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple recipients in Ledger BTC flow #512

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

Imamah-Zafar
Copy link
Contributor

@Imamah-Zafar Imamah-Zafar commented Jul 10, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

Allows multiple btc and ordinal recipients.
Core changes: secretkeylabs/xverse-core#165

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

Changes type of recipient to array.

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

🧪 Testing Instruction

All the ledger transactions , BTC (single and multiple recipients), ordinals and BRC20 transfers need to be tested to ensure that everything works as expected

@DuskaT021 DuskaT021 requested a review from dhriaznov July 13, 2023 05:27
@dhriaznov dhriaznov merged commit f232ac3 into ledger-btc-mvp Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants