Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize stx transactions navigation params #514

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

m-aboelenein
Copy link
Member

πŸ”˜ PR Type

What kind of change does this PR introduce?

Fix for errors thrown by parsing errors while passing transactions between the send-stx screen and the confirm-stx-tx / confirm-ft-tx screens

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

πŸ“œ Background

failure to navigate to the stx confirm screens without visual response on what went wrong

Issue Link: https://linear.app/xverseapp/issue/ENG-2410/cant-send-stx-and-sip-10-tokens

πŸ”„ Changes

stx transactions are serialized then deserialized when being passed as navigation params

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@linear
Copy link

linear bot commented Jul 11, 2023

ENG-2410 Can't send stx and sip-10 tokens

Send STX screen || Send sip-10 tokens || Send STX NFT screen:

made sure I built the extension properly

not able to send stx or other sip-10 tokens, due to an app state error, it doesn't have the STX address in state

The issue is present on the latest develop, not present on production (web-store build)

This issue is a release-blocker

Network response when clicking Next button in the mentioned Send screens:

image.png

011e1028-994e-457b-8a3c-66ee8f459819

@m-aboelenein m-aboelenein self-assigned this Jul 11, 2023
@m-aboelenein m-aboelenein added the bug Something isn't working label Jul 11, 2023
@DuskaT021
Copy link
Contributor

left a comment in the linear ticket ENG-2410

@DuskaT021
Copy link
Contributor

tested it can be merged

@DuskaT021 DuskaT021 requested a review from yknl July 14, 2023 14:10
@teebszet
Copy link
Member

lgtm

@DuskaT021 DuskaT021 merged commit 8259a5d into develop Jul 17, 2023
1 check passed
@teebszet teebszet deleted the mahmoud/eng-2410-cant-send-stx-and-sip-10-tokens branch November 23, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants