Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate alex swaps with stacks transaction sponsor #515

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 12, 2023

🔘 PR Type

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

UI for sponsored transactions on swaps. depends on a xverse-core change in 1.3.0

Issue Link: https://linear.app/xverseapp/issue/ENG-2400/implement-web-extension-ui-for-sponsorednon-sponsored-swaps
Context Link (if applicable):

🔄 Changes

  • create a react hook for checking if a stacks-transaction-sponsor service is active
  • integrate with hook when deciding to show "This transaction is sponsored" UI or not
  • integrate with xverse-core to sponsor a swap transaction if the service is active

Impact:

  • swaps sponsorship UI and broadcast transaction

🖼 Screenshot / 📹 Video

UI when sponsor is active:
image

UI when sponsor is not active:
image

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@teebszet teebszet changed the base branch from develop to feat/swap July 12, 2023 04:07
@teebszet teebszet force-pushed the tim/eng-2377-integrate-alex-swaps-with-stacks-transaction-sponsor branch from 4272e29 to 3654327 Compare July 18, 2023 08:47
@teebszet teebszet changed the title Tim/eng 2377 integrate alex swaps with stacks transaction sponsor Integrate alex swaps with stacks transaction sponsor Jul 18, 2023
@teebszet teebszet merged commit cb9f2ad into feat/swap Jul 18, 2023
@teebszet teebszet deleted the tim/eng-2377-integrate-alex-swaps-with-stacks-transaction-sponsor branch November 23, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants