Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordinals display issue #517

Merged

Conversation

Imamah-Zafar
Copy link
Contributor

@Imamah-Zafar Imamah-Zafar commented Jul 14, 2023

πŸ”˜ PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

πŸ“œ Background

When restoring a wallet with ordinals and getting a prompt to activate display of ordinals, pressing activate does not actually activate display until switching to a different tab and coming back.
Issue Link: #[2388]

πŸ”„ Changes

Update the dependency array for NftListView

πŸ–Ό Screenshot / πŸ“Ή Video

ledger.mov

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@linear
Copy link

linear bot commented Jul 14, 2023

ENG-2388 Activate Ordinals display issue

When restoring a wallet with ordinals and getting a prompt to activate display of ordinals, pressing activate does not actually activate display until switching to a different tab and coming back.

dbfa599c-ebfc-4f21-9d3f-ea8f4f315c34

@Imamah-Zafar Imamah-Zafar self-assigned this Jul 14, 2023
@DuskaT021
Copy link
Contributor

this can be merged

@DuskaT021 DuskaT021 merged commit 9a88249 into ledger-btc-mvp Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants