Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ledger account name UI issue #530

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

dhriaznov
Copy link
Contributor

@dhriaznov dhriaznov commented Jul 25, 2023

πŸ”˜ PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

πŸ“œ Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: https://linear.app/xverseapp/issue/ENG-2486/fix-ledger-account-name-ui-issue
Context Link (if applicable):

πŸ”„ Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

πŸ–Ό Screenshot / πŸ“Ή Video

Monosnap Xverse Wallet 2023-07-25 10-25-16 Monosnap Xverse Wallet 2023-07-25 10-25-26

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@dhriaznov dhriaznov requested review from teebszet and yknl July 25, 2023 08:26
@dhriaznov dhriaznov self-assigned this Jul 25, 2023
@linear
Copy link

linear bot commented Jul 25, 2023

ENG-2486 Fix ledger account name UI issue

In the release/v0.14.0 branch, the Ledger account name input box has a white background and white text color.

image.png

@github-actions
Copy link

@yknl yknl changed the base branch from develop to release/v0.14.0 July 25, 2023 17:41
@yknl yknl merged commit f1986aa into release/v0.14.0 Jul 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants