Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show inscription service fee fiat amount #531

Merged

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 25, 2023

🔘 PR Type

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

We show the fiat amount for all line items in the BRC-20 transfer confirmation screen but not the inscription service fee.
image

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

changes:

  • show the inscription service fee amount converted to fiat rate

Impact:

  • only a UI change on confirm brc20 send screen

🖼 Screenshot / 📹 Video

image

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@linear
Copy link

linear bot commented Jul 25, 2023

ENG-2332 Show fiat amount for inscription service fee

We show the fiat amount for all line items in the BRC-20 transfer confirmation screen but not the inscription service fee.

image.png

@teebszet teebszet changed the title fix: show inscription service fee fiat amount feat: show inscription service fee fiat amount Jul 25, 2023
@github-actions
Copy link

@yknl
Copy link
Contributor

yknl commented Jul 27, 2023

tested

@yknl yknl merged commit 3ffcc02 into develop Jul 27, 2023
2 checks passed
@teebszet teebszet deleted the tim/eng-2332-show-fiat-amount-for-inscription-service-fee branch July 28, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants