Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show swaps button if not on a ledger account #536

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 28, 2023

πŸ”˜ PR Type

  • Bugfix

πŸ“œ Background

Issue Link: https://linear.app/xverseapp/issue/ENG-2508/disable-swaps-for-ledger-accounts

πŸ”„ Changes

  • add logic to show/hide the Swap button depending on selected account being ledger or not

Impact:

  • only on home screen, show/hide of the Swap button

πŸ–Ό Screenshot / πŸ“Ή Video

disable-swaps-on-ledger-account.mov

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@linear
Copy link

linear bot commented Jul 28, 2023

ENG-2508 Disable swaps for Ledger accounts

Currently we don't support STX with Ledger so we should disable the swaps button on ledger accounts.

image.png

@teebszet teebszet requested a review from dhriaznov July 28, 2023 06:26
@github-actions
Copy link

Copy link
Contributor

@dhriaznov dhriaznov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, works fine πŸ‘

@yknl yknl merged commit f6144bc into develop Aug 1, 2023
2 checks passed
@teebszet teebszet deleted the tim/eng-2508-disable-swaps-for-ledger-accounts branch August 1, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants