Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim/eng 2510 not all tokens in token list can be swapped #541

Merged

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 31, 2023

πŸ”˜ PR Type

  • Bugfix

πŸ“œ Background

see linear. temporary change while ALEX work on their API

Issue Link: https://linear.app/xverseapp/issue/ENG-2510/not-all-tokens-in-token-list-can-be-swapped
Context Link (if applicable):

πŸ”„ Changes

  • add a filter out list for swaps supported coins
  • fix for h1 nested in h1 errors
  • use more semantic html instead of using all h1 elements

Impact:

  • swaps token select from/to

πŸ–Ό Screenshot / πŸ“Ή Video

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@linear
Copy link

linear bot commented Jul 31, 2023

ENG-2510 Not all tokens in token list can be swapped

The list of tokens to convert needs to take into account which ones are swappable.

For example, $B20 is not currently available for swaps on ALEX

https://app.alexlab.co/swap

When you select it, you will not get a quote.

Check if ALEX has an API to check which tokens can be swapped.

image.png

@teebszet teebszet requested a review from dhriaznov July 31, 2023 11:44
@github-actions
Copy link

@yknl yknl merged commit a71cbb8 into develop Aug 1, 2023
2 checks passed
@teebszet teebszet deleted the tim/eng-2510-not-all-tokens-in-token-list-can-be-swapped branch August 1, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants