Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toString to convert value to BigNumber #543

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

Imamah-Zafar
Copy link
Contributor

@Imamah-Zafar Imamah-Zafar commented Aug 1, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

With the current implementation, we currently get the error Argument of type 'bigint' is not assignable to parameter of type 'Value'
Noticed this while testing secretkeylabs/sats-connect#25

🔄 Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

@yknl
Copy link
Contributor

yknl commented Aug 1, 2023

Is this an issue on mobile @abdulhaseeb4239 ?

@yknl yknl merged commit 540da83 into develop Aug 1, 2023
2 checks passed
@teebszet teebszet deleted the imamahzafar/bignumber-coversion-change branch August 2, 2023 03:31
@abdulhaseeb4239
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants