Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim/eng 2510 decouple list of swap tokens #547

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Aug 2, 2023

πŸ”˜ PR Type

  • Bugfix

πŸ“œ Background

Previously the alex swap token list (from/to) was controlled by visible tokens list (set by user on home screen)

Instead want the list to match that of alex swap dapp

Issue Link: https://linear.app/xverseapp/issue/ENG-2510/not-all-tokens-in-token-list-can-be-swapped
Context Link (if applicable): https://github.com/secretkeylabs/xverse-api/pull/191

πŸ”„ Changes

  • remove token uppercase enforcement
  • decouple list of allowable swap tokens from visible tokens list set by the user

Impact:

  • token ticker (xBTC, BTC, ALEX, sUSDT) are no longer all uppercase

πŸ–Ό Screenshot / πŸ“Ή Video

swap tokens from/to list:
image

image

home screen token list (depends on user setting of visible tokens):
image

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@teebszet teebszet requested a review from yknl August 2, 2023 07:12
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@yknl
Copy link
Contributor

yknl commented Aug 3, 2023

Tested

@yknl yknl merged commit 0e8779e into develop Aug 3, 2023
2 checks passed
@teebszet teebszet deleted the tim/eng-2510-hardcode-list-of-swap-tokens branch November 23, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants