Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swaps tx history #557

Merged
merged 5 commits into from
Aug 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/app/components/transactions/stxTransaction.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@ import StxTransferTransaction from './stxTransferTransaction';
interface TransactionHistoryItemProps {
transaction: AddressTransactionWithTransfers | Tx;
transactionCoin: CurrencyTypes;
txFilter: string | null;
}

export default function StxTransactionHistoryItem(props: TransactionHistoryItemProps) {
const { transaction, transactionCoin } = props;
const { transaction, transactionCoin, txFilter } = props;
const { selectedAccount } = useWalletSelector();
// const { t } = useTranslation('translation', { keyPrefix: 'COIN_DASHBOARD_SCREEN' });
if (!isAddressTransactionWithTransfers(transaction)) {
Expand Down Expand Up @@ -68,7 +69,7 @@ export default function StxTransactionHistoryItem(props: TransactionHistoryItemP
}
return (
<>
<TxTransfers transaction={transaction} coin={transactionCoin} />
<TxTransfers transaction={transaction} coin={transactionCoin} txFilter={txFilter} />
<StxTransferTransaction
transaction={parseStxTransactionData({
responseTx: transaction.tx,
Expand Down
43 changes: 31 additions & 12 deletions src/app/components/transactions/txTransfers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { NumericFormat } from 'react-number-format';
import { microstacksToStx } from '@secretkeylabs/xverse-core';
import BigNumber from 'bignumber.js';
import { useTranslation } from 'react-i18next';
import { getFtTicker } from '@utils/tokens';

const TransactionContainer = styled.div((props) => ({
display: 'flex',
Expand Down Expand Up @@ -51,11 +52,12 @@ const TransactionValue = styled.p((props) => ({
interface TxTransfersProps {
transaction: AddressTransactionWithTransfers;
coin: CurrencyTypes;
txFilter: string | null;
}

export default function TxTransfers(props: TxTransfersProps) {
const { transaction, coin } = props;
const { selectedAccount } = useWalletSelector();
const { transaction, coin, txFilter } = props;
const { selectedAccount, coinsList } = useWalletSelector();
const { t } = useTranslation('translation', { keyPrefix: 'COIN_DASHBOARD_SCREEN' });

function formatAddress(addr: string): string {
Expand All @@ -73,28 +75,45 @@ export default function TxTransfers(props: TxTransfersProps) {
selectedAccount?.stxAddress === transfer.recipient
? t('TRANSACTION_RECEIVED')
: t('TRANSACTION_SENT');
return (
<>
{transaction.stx_transfers.map((stxTransfer) => (

function renderTransaction(transactionList) {
return transactionList.map((transfer) => {
const isFT = coin === 'FT';
const ft = coinsList?.find((ftCoin) => ftCoin.principal === txFilter!.split('::')[0]);
const isSentTransaction = selectedAccount?.stxAddress !== transfer.recipient;
if (isFT && transfer.asset_identifier !== txFilter) {
return null;
}

return (
<TransactionContainer key={nanoid()}>
{renderTransactionIcon(stxTransfer)}
{renderTransactionIcon(transfer)}
<TransactionInfoContainer>
<TransactionRow>
<TransactionTitleText>{getTokenTransferTitle(stxTransfer)}</TransactionTitleText>
<TransactionTitleText>{getTokenTransferTitle(transfer)}</TransactionTitleText>
<NumericFormat
value={microstacksToStx(BigNumber(stxTransfer.amount)).toString()}
value={microstacksToStx(BigNumber(transfer.amount)).toString()}
displayType="text"
thousandSeparator
prefix={selectedAccount?.stxAddress === stxTransfer.recipient ? '' : '-'}
prefix={isSentTransaction ? '-' : ''}
renderText={(value: string) => (
<TransactionValue>{`${value} ${coin}`}</TransactionValue>
<TransactionValue>
{`${value} ${isFT && ft ? getFtTicker(ft) : coin}`}
</TransactionValue>
)}
/>
</TransactionRow>
<RecipientAddress>{formatAddress(stxTransfer.recipient as string)}</RecipientAddress>
<RecipientAddress>{formatAddress(transfer.recipient as string)}</RecipientAddress>
</TransactionInfoContainer>
</TransactionContainer>
))}
);
});
}
return (
<>
{coin === 'FT' && transaction.ft_transfers
? renderTransaction(transaction.ft_transfers)
: renderTransaction(transaction.stx_transfers)}
</>
);
}
1 change: 1 addition & 0 deletions src/app/screens/coinDashboard/transactionsHistoryList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export default function TransactionsHistoryList(props: TransactionsHistoryListPr
transaction={transaction}
transactionCoin={coin}
key={transaction.tx_id}
txFilter={txFilter}
/>
);
})}
Expand Down