-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove bignumber from the redux store #610
fix: remove bignumber from the redux store #610
Conversation
β¦-ordinals-is-no-longer-able-to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure to test the Ledger send BRC-20 flow given the typing issue.
@victorkirov can we resolve this conflict, tnx |
β¦-ordinals-is-no-longer-able-to
@victorkirov kindly resolve the conflicts so this PR can be picked up for testing too |
β¦-extension into victor/eng-2981-power-user-with-over-3000-ordinals-is-no-longer-able-to
This PR will be picked up after the seed vault PR is merged -- as per the discussion with @victorkirov |
Hey @victorkirov could you resolve this conflicts so the testing for this PR can be started? |
β¦-extension into victor/eng-2981-power-user-with-over-3000-ordinals-is-no-longer-able-to
β¦-ordinals-is-no-longer-able-to
β¦-ordinals-is-no-longer-able-to
@blehitsahmad this is ready for retest |
@DuskaT021 could you kindly take a look at the ledger BRC20 send flow for this PR -- I have tested the rest. The test cases can be found here |
β¦-ordinals-is-no-longer-able-to
β¦-ordinals-is-no-longer-able-to
|
@victorkirov this is tested and can be merged |
π PR Type
What kind of change does this PR introduce?
π Background
When changing settings, if you have multiple tabs open, the saved settings are overwritten by the last tab that is closed, and settings are not propagated across tabs. This is due to the store sync not syncing everything, which was disabled because we had class instances in the store.
π Changes
All BigNumber instances were removed from the store and the values were cast to BigNumber where needed throughout the code. A number of other components were also changed to fix any linting and typing issues that were blocking commits.
Impact:
πΌ Screenshot / πΉ Video
Before:
Screen.Recording.2023-10-05.at.14.18.30.mov
After:
Screen.Recording.2023-10-05.at.14.19.55.mov
β Review checklist
Please ensure the following are true before merging: